Enable specifying prefixed zone names in DNSRecord spec.zone
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
/invite @MartinWeindel @plkokanov |
stoyanr
changed the title
DNSRecord spec.zone
gardener-robot
added
reviewed/lgtm
stoyanr
added
reviewed/ok-to-test
stoyanr
force-pushed
the
fix-dnsrecord-zone-format
branch
from
8e43d2b
to
36c2e6c
Compare
gardener-robot
added
needs/review
gardener-robot-ci-3
added
needs/ok-to-test
MartinWeindel
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform gcp
What this PR does / why we need it:
Enables specifying a zone name prefixed with the project id, in addition to an unprefixed zone name, in the
spec.zonefield of aDNSRecordresource. This is needed to ensure that explicitly configured zones in landscapes and shootspec.dns.providersconfigurations work for both theDNSRecordcontroller and external-dns-management, which always uses prefixed zone names on GCP.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
external-dns-management, it is important to be able to configure zones explicitly in a way that works for bothexternal-dns-managementand theDNSRecordcontroller. Since the handling of zones inexternal-dns-managementis harder to change, this PR proposes adapting theDNSRecordcontroller to the zone identification used byexternal-dns-management.Release note: