-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specifying prefixed zone names in DNSRecord
spec.zone
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
Control plane related
kind/enhancement
Enhancement, improvement, extension
platform/gcp
Google cloud platform/infrastructure
needs/review
Needs review
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Nov 12, 2021
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 12, 2021
/invite @MartinWeindel @plkokanov |
stoyanr
changed the title
Enable specifying prefixed zone names in DNSRecord spec.zone
Enable specifying prefixed zone names in Nov 12, 2021
DNSRecord
spec.zone
MartinWeindel
previously approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Nov 12, 2021
stoyanr
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 12, 2021
stoyanr
force-pushed
the
fix-dnsrecord-zone-format
branch
from
November 12, 2021 16:49
8e43d2b
to
36c2e6c
Compare
gardener-robot
added
needs/review
Needs review
and removed
needs/review
Needs review
labels
Nov 12, 2021
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 12, 2021
MartinWeindel
approved these changes
Nov 15, 2021
dkistner
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/gcp
Google cloud platform/infrastructure
reviewed/lgtm
Has approval for merging
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform gcp
What this PR does / why we need it:
Enables specifying a zone name prefixed with the project id, in addition to an unprefixed zone name, in the
spec.zone
field of aDNSRecord
resource. This is needed to ensure that explicitly configured zones in landscapes and shootspec.dns.providers
configurations work for both theDNSRecord
controller and external-dns-management, which always uses prefixed zone names on GCP.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
external-dns-management
, it is important to be able to configure zones explicitly in a way that works for bothexternal-dns-management
and theDNSRecord
controller. Since the handling of zones inexternal-dns-management
is harder to change, this PR proposes adapting theDNSRecord
controller to the zone identification used byexternal-dns-management
.Release note: